IndexFile._to_relative_path - fix case where absolute path gets stripped of trailing slash - #2012
Merged
Conversation
kamilkozik7
force-pushed
the
fix-trailing-slash
branch
3 times, most recently
from
March 7, 2025 17:55
2bbb6ee to
3a40c1c
Compare
kamilkozik7
marked this pull request as ready for review
March 7, 2025 18:07
…ipped of trailing slash
Byron
force-pushed
the
fix-trailing-slash
branch
from
March 12, 2025 12:31
3a40c1c to
11f7faf
Compare
Byron
approved these changes
Mar 12, 2025
Byron
left a comment
Byron
left a comment
Member
There was a problem hiding this comment.
Great, thanks a lot for the fix!
Looks good to me, too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered this issue on MacOS, python 3.7 and later
Added fix and appropriate unit test.
Stripping of trailing slash seems to be happening in
os.path.relpath, altough I am not sure whether that is expected behaviour. In case it is not expected, and ever gets fixed, I added an additional check (and not result.endswith(os.sep)) to make sure that the trailing slash doesn't get duplicated.