fix: wait for git daemon to listen before connecting - #2219
Merged
Conversation
Properly wait instead of hardcoding a short sleep. Fixes gitpython-developers#1676
Vogtinator
force-pushed
the
main
branch
2 times, most recently
from
August 27, 2026 14:24
32475bc to
db1a2cf
Compare
Byron
approved these changes
Aug 28, 2026
Byron
left a comment
Byron
left a comment
Member
There was a problem hiding this comment.
Let's go with this, thank you!
A follow-up could mean to reduce the time to sleep, as I'd expect the socket to become available much earlier, which should make dependent tests start running a little bit faster.
Contributor
Author
|
The ideal fix is to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly wait instead of hardcoding a short sleep.
Fixes #1676