Skip to content

perf: prevent repeated status fetches in large repos #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DannyStoll1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: prevent repeated status fetches in large repos #2824

DannyStoll1 wants to merge 1 commit into from

Conversation

@DannyStoll1
Copy link

@DannyStoll1 DannyStoll1 commented Dec 31, 2025

This PR fixes/closes #2823

It changes the following:

  • Remove tick from StatusParams hash
  • Add generation counter that increments after each fetch completes
  • Include generation in cache hash

This ensures:

  • No repeated fetches while one is already pending, making gitui usable in very large repos
  • New fetch starts immediately after completion, keeping gitui responsive in small repos
  • External file changes will still be detected on the next fetch cycle

I followed the checklist:

  • No added unittests: the change is a behavioral fix to existing code, and the existing tests pass
  • I ran make check without errors
  • I tested the overall application: on my 1.7M file target repository, load time goes from 5+ minutes to ~2.5 seconds
  • I added an appropriate item to the changelog
perf: prevent repeated status fetches in large repos
c9ccd5e 
Replace time-based cache invalidation with a generation counter.

The old `StatusParams` included a millisecond timestamp (tick) in its
hash, causing the cache to invalidate on every UI tick. For large repos
with millions of files, this led to repeated index loading and 5+ minute load times.

This change uses a different strategy to manage cache invalidation:
- Remove tick from StatusParams hash
- Add generation counter that increments after each fetch completes
- Include generation in cache hash

This ensures:
- No repeated fetches while one is already pending, making gitui usable
  in large repos
- New fetch starts immediately after completion, keeping gitui responsive
  in small repos
- External file changes will still be detected on the next fetch cycle
@extrawurst
Copy link
Collaborator

extrawurst commented Dec 31, 2025

Oh wow interesting, I wonder when we broke that. Great find
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@DannyStoll1 @extrawurst