Skip to content

tests: calling os.Exit in TestMain is not required #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2024
Merged

tests: calling os.Exit in TestMain is not required #3856

merged 1 commit into from
Nov 12, 2024

Conversation

@alexandear
Copy link
Contributor

This PR simplifies tests by removing os.Exit calls in TestMain. It's not needed from Go 1.15, see golang/go#34129.

Additionally, this PR updates the comment for RunTestsWithFixtures.
@alexandear alexandear force-pushed the tests-refactor-test-main branch from 8e0dc0b to 010798f Compare November 7, 2024 19:41
aarzilli
aarzilli approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
derekparker
derekparker approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@derekparker derekparker merged commit b4cfc8f into go-delve:master Nov 12, 2024
2 checks passed
@alexandear alexandear deleted the tests-refactor-test-main branch November 12, 2024 16:10
@alexandear alexandear mentioned this pull request Dec 12, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@alexandear @aarzilli @derekparker