fix: Missing repo name in push mirror system message #36266
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a push mirror's repository no longer exists, the previous code ignored the return value of GetRepository(), leading to nil pointer access when constructing the process description. This resulted in empty repository names in system messages. This fix checks if GetRepository() returns nil and exits early with an error log, preventing the use of nil repository fields. Fixes go-gitea#36211 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
GiteaBot
added
the
lgtm/need 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #36211
Changes
When a push mirror's repository no longer exists, the previous code ignored the return value of GetRepository(), which could lead to nil pointer access when constructing the process description at line 102. This resulted in empty repository names in system messages.
This fix checks if GetRepository() returns nil and exits early with an error log, preventing the use of nil repository fields.
Generated with Claude Code