Open
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
Contributor
Author
|
Addressed the open review threads with the following changes:
Validation run:
|
wxiaoguang
reviewed
Feb 26, 2026
wxiaoguang
reviewed
Feb 26, 2026
bircni
force-pushed
the
feature/retry-badges
branch
from
56aeab8 to
5cbe732
Compare
lunny
reviewed
Feb 26, 2026
lunny
reviewed
Feb 26, 2026
lunny
reviewed
Feb 26, 2026
Member
|
It's better to have a user name search when inputing like other places. |
Member
Align problem.
|
Contributor
Author
|
fixed |
lunny
approved these changes
Feb 26, 2026
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
previously requested changes
Feb 27, 2026
Contributor
wxiaoguang
left a comment
wxiaoguang
left a comment
There was a problem hiding this comment.
Need more improvements
GiteaBot
added
lgtm/blocked
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
reviewed
Feb 27, 2026
wxiaoguang
reviewed
Feb 28, 2026
| func TestDeleteBadgeUserRedirectEscapesSlug(t *testing.T) { | ||
| unittest.PrepareTestEnv(t) | ||
| ctx, resp := contexttest.MockContext(t, "POST /-/admin/badges/slug/badge/users/delete") | ||
| ctx.SetPathParam("badge_slug", "badge/slug with space") |
Contributor
There was a problem hiding this comment.
Why it can happen
This test seems not useful and unnecessary
wxiaoguang
reviewed
Feb 28, 2026
Comment on lines
+9
to
+10
| <label for="slug">{{ctx.Locale.Tr "admin.badges.slug"}}</label> | ||
| <input autofocus required id="slug" name="slug"> |
Contributor
There was a problem hiding this comment.
No need to use for / id . Framework will add them
wxiaoguang
reviewed
Feb 28, 2026
| // ErrInvalidGroupTeamMap is returned when a group team mapping is invalid | ||
| ErrInvalidGroupTeamMap = "InvalidGroupTeamMap" | ||
| // ErrInvalidSlug is returned when a slug is invalid | ||
| ErrInvalidSlug = "InvalidSlug" |
Contributor
There was a problem hiding this comment.
ErrInvalidBadgeSlug = "InvalidBadgeSlug"
wxiaoguang
reviewed
Feb 28, 2026
| func addSlugPatternRule() { | ||
| binding.AddRule(&binding.Rule{ | ||
| IsMatch: func(rule string) bool { | ||
| return rule == "Slug" |
wxiaoguang
reviewed
Feb 28, 2026
Comment on lines
+40
to
+43
| if sortType == "" { | ||
| sortType = BadgeSearchDefaultAdminSort | ||
| ctx.SetFormString("sort", sortType) | ||
| } |
Contributor
There was a problem hiding this comment.
RenderBadgeSearch already does correct fall-back.
These if / SetFormString actually helps nothing
wxiaoguang
reviewed
Feb 28, 2026
Comment on lines
+22
to
+27
| <div class="menu"> | ||
| <button class="item" name="sort" value="oldest">{{ctx.Locale.Tr "repo.issues.filter_sort.oldest"}}</button> | ||
| <button class="item" name="sort" value="newest">{{ctx.Locale.Tr "repo.issues.filter_sort.latest"}}</button> | ||
| <button class="item" name="sort" value="alphabetically">{{ctx.Locale.Tr "repo.issues.label.filter_sort.alphabetically"}}</button> | ||
| <button class="item" name="sort" value="reversealphabetically">{{ctx.Locale.Tr "repo.issues.label.filter_sort.reverse_alphabetically"}}</button> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Is there a bug? No item will be selected even if end user chooses one. I haven't tested.
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Mar 1, 2026
Comment on lines
+31
to
+32
| validSlugPattern: regexp.MustCompile(`^[\da-zA-Z][-.\w]*$`), | ||
| invalidSlugPattern: regexp.MustCompile(`[-._]{2,}|[-._]$`), |
Contributor
There was a problem hiding this comment.
What are the proper patterns for "badge slug"?
Should it support names like "Awesome!" or "Emoji 💯" ? ( I think no, it only uses image)
If it is not designed to support these patterns, then the test ( https://github.com/go-gitea/gitea/pull/36752/files#r2867004215 ) seems not useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trying to reenable #31262