Skip to content

Fix registration token API#36793

Open
lunny wants to merge 2 commits intogo-gitea:mainfrom
lunny:lunny/fix_registor_token
Open

Fix registration token API#36793
lunny wants to merge 2 commits intogo-gitea:mainfrom
lunny:lunny/fix_registor_token

Conversation

@lunny
Copy link
Member

@lunny lunny commented Mar 1, 2026

Another possible resolution is to remove GET method.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2026
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Mar 1, 2026
Copy link
Contributor

@Zettat123 Zettat123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. However, I would prefer to remove the GET method because:

  • it's not a real GET method
  • GH doesn't support GET and only POST is allowed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v1.25 lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug

3 participants