fix: on confilct with default value #6434

black-06 · 2023-06-28T05:35:16Z

Do only one thing
Non breaking API changes
Tested

What did this pull request do?

close #6418 ,
and it has a little relationship with #6129

User Case Description

jinzhu · 2023-07-24T12:13:54Z

Which might cause a column's value overwritten by an empty value, here is an example:

type User struct {
   Name string
  UUID   string `gorm:"default:gen_random_uuid()"`
}

db.Save(&[]User{{Name: "name"}}

black-06 · 2023-07-25T08:34:31Z

Hi @black-06

Which might cause a column's value overwritten by an empty value, here is an example:
type User struct {
   Name string
  UUID   string `gorm:"default:gen_random_uuid()"`
}

db.Save(&[]User{{Name: "name"}}

~~OK, I will fix it~~

black-06 · 2023-07-25T10:21:36Z

Hi @black-06

Which might cause a column's value overwritten by an empty value, here is an example:
type User struct {
   Name string
  UUID   string `gorm:"default:gen_random_uuid()"`
}

db.Save(&[]User{{Name: "name"}}

Uh, the same case at playground failed, see go-gorm/playground#629.
This bug may not be caused by this mr.
If they are not related, I will fix it in the new mr

black-06 · 2023-07-27T12:18:14Z

Hi @black-06

Which might cause a column's value overwritten by an empty value, here is an example:
type User struct {
   Name string
  UUID   string `gorm:"default:gen_random_uuid()"`
}

db.Save(&[]User{{Name: "name"}}

Sorry, I may not understand what you mean.
I wrote a test and it seems to work fine.

func TestSaveWithDefaultValue(t *testing.T) {
	if DB.Dialector.Name() != "postgres" {
		t.Skip()
	}

	type WithDefaultValue struct {
		Name string `gorm:"primaryKey"`
		UUID string `gorm:"default:gen_random_uuid()"`
	}

	err := DB.Migrator().DropTable(&WithDefaultValue{})
	AssertEqual(t, err, nil)
	err = DB.AutoMigrate(&WithDefaultValue{})
	AssertEqual(t, err, nil)

	// INSERT INTO "with_default_values" ("name") VALUES ('jinzhu') ON CONFLICT ("name") DO NOTHING RETURNING "uuid"
	err = DB.Debug().Save(&[]WithDefaultValue{{Name: "jinzhu"}}).Error
	AssertEqual(t, err, nil)

	err = DB.Debug().Save(&[]WithDefaultValue{{Name: "jinzhu"}}).Error
	AssertEqual(t, err, nil)
}

@a631807682 Would you mind helping me? 😄

a631807682 · 2023-07-27T13:17:46Z

Hi @black-06
Which might cause a column's value overwritten by an empty value, here is an example:
type User struct {
   Name string
  UUID   string `gorm:"default:gen_random_uuid()"`
}

db.Save(&[]User{{Name: "name"}}

Sorry, I may not understand what you mean. I wrote a test and it seems to work fine.

func TestSaveWithDefaultValue(t *testing.T) {
	if DB.Dialector.Name() != "postgres" {
		t.Skip()
	}

	type WithDefaultValue struct {
		Name string `gorm:"primaryKey"`
		UUID string `gorm:"default:gen_random_uuid()"`
	}

	err := DB.Migrator().DropTable(&WithDefaultValue{})
	AssertEqual(t, err, nil)
	err = DB.AutoMigrate(&WithDefaultValue{})
	AssertEqual(t, err, nil)

	// INSERT INTO "with_default_values" ("name") VALUES ('jinzhu') ON CONFLICT ("name") DO NOTHING RETURNING "uuid"
	err = DB.Debug().Save(&[]WithDefaultValue{{Name: "jinzhu"}}).Error
	AssertEqual(t, err, nil)

	err = DB.Debug().Save(&[]WithDefaultValue{{Name: "jinzhu"}}).Error
	AssertEqual(t, err, nil)
}

@a631807682 Would you mind helping me? 😄

I'll check it tomorrow

a631807682

values.Columns is already filtered data, it must not contain default value, or contain default value and set a value for it at the same time.

The problem here is that if the default value is a database built-in function ( just like gen_random_uuid() or now(), we don't parse DefaultValueInterface), we don't override it. But for custom types, we do not provide a way to override DefaultValueInterface, so it is always excluded.

Here is a smaller example

	type WithDefaultValue struct {
		Name    string            `gorm:"primaryKey"`
		Content datatypes.JSONMap `gorm:"default:'{}'"`
	}

	err := DB.Migrator().DropTable(&WithDefaultValue{})
	AssertEqual(t, err, nil)
	err = DB.AutoMigrate(&WithDefaultValue{})
	AssertEqual(t, err, nil)

	dfv := WithDefaultValue{Name: "jinzhu"}
	err = DB.Save(&dfv).Error
	AssertEqual(t, err, nil)

	dfv.Content["name"] = "jinzhu"
	err = DB.Clauses(clause.OnConflict{UpdateAll: true}).Create(&dfv).Error
	AssertEqual(t, err, nil)

	var result WithDefaultValue
	err = DB.First(&result).Error
	AssertEqual(t, err, nil)
	AssertEqual(t, result.Content["name"], "jinzhu")

black-06 · 2023-07-28T06:58:49Z

values.Columns is already filtered data, it must not contain default value, or contain default value and set a value for it at the same time.

The problem here is that if the default value is a database built-in function ( just like gen_random_uuid() or now(), we don't parse DefaultValueInterface), we don't override it. But for custom types, we do not provide a way to override DefaultValueInterface, so it is always excluded.

Here is a smaller example
	type WithDefaultValue struct {
		Name    string            `gorm:"primaryKey"`
		Content datatypes.JSONMap `gorm:"default:'{}'"`
	}

	err := DB.Migrator().DropTable(&WithDefaultValue{})
	AssertEqual(t, err, nil)
	err = DB.AutoMigrate(&WithDefaultValue{})
	AssertEqual(t, err, nil)

	dfv := WithDefaultValue{Name: "jinzhu"}
	err = DB.Save(&dfv).Error
	AssertEqual(t, err, nil)

	dfv.Content["name"] = "jinzhu"
	err = DB.Clauses(clause.OnConflict{UpdateAll: true}).Create(&dfv).Error
	AssertEqual(t, err, nil)

	var result WithDefaultValue
	err = DB.First(&result).Error
	AssertEqual(t, err, nil)
	AssertEqual(t, result.Content["name"], "jinzhu")

I'm still thinking about your comment, but your test didn't fail...

name	content
jinzhu	{"name": "jinzhu"}

a631807682 · 2023-07-28T07:01:54Z

values.Columns is already filtered data, it must not contain default value, or contain default value and set a value for it at the same time.
The problem here is that if the default value is a database built-in function ( just like gen_random_uuid() or now(), we don't parse DefaultValueInterface), we don't override it. But for custom types, we do not provide a way to override DefaultValueInterface, so it is always excluded.
Here is a smaller example
	type WithDefaultValue struct {
		Name    string            `gorm:"primaryKey"`
		Content datatypes.JSONMap `gorm:"default:'{}'"`
	}

	err := DB.Migrator().DropTable(&WithDefaultValue{})
	AssertEqual(t, err, nil)
	err = DB.AutoMigrate(&WithDefaultValue{})
	AssertEqual(t, err, nil)

	dfv := WithDefaultValue{Name: "jinzhu"}
	err = DB.Save(&dfv).Error
	AssertEqual(t, err, nil)

	dfv.Content["name"] = "jinzhu"
	err = DB.Clauses(clause.OnConflict{UpdateAll: true}).Create(&dfv).Error
	AssertEqual(t, err, nil)

	var result WithDefaultValue
	err = DB.First(&result).Error
	AssertEqual(t, err, nil)
	AssertEqual(t, result.Content["name"], "jinzhu")
I'm still thinking about your comment, but your test didn't fail...

name content
jinzhu {"name": "jinzhu"}

Sorry, this test is to illustrate the problem with custom types before.
You can use default:gen_random_uuid(), you will find that it keeps updating the UUID.

black-06 · 2023-07-28T07:13:53Z

You can use default:gen_random_uuid(), you will find that it keeps updating the UUID.

It didn't... Still this test, It was saved twice, but the uuid did not change.

func TestSaveWithDefaultValue(t *testing.T) {
	if DB.Dialector.Name() != "postgres" {
		t.Skip()
	}

	type WithDefaultValue struct {
		Name string `gorm:"primaryKey"`
		UUID string `gorm:"default:gen_random_uuid()"`
	}

	err := DB.Migrator().DropTable(&WithDefaultValue{})
	AssertEqual(t, err, nil)
	err = DB.AutoMigrate(&WithDefaultValue{})
	AssertEqual(t, err, nil)

	// INSERT INTO "with_default_values" ("name") VALUES ('jinzhu') ON CONFLICT ("name") DO NOTHING RETURNING "uuid"
	err = DB.Debug().Save(&[]WithDefaultValue{{Name: "jinzhu"}}).Error
	AssertEqual(t, err, nil)

	err = DB.Debug().Save(&[]WithDefaultValue{{Name: "jinzhu"}}).Error
	AssertEqual(t, err, nil)
}

a631807682 · 2023-07-28T14:26:38Z

As #6434 (review) says, if the value is not set, it will not be overridden, whereas if the value is set it should be.

Hi @black-06

Which might cause a column's value overwritten by an empty value, here is an example:
type User struct {
   Name string
  UUID   string `gorm:"default:gen_random_uuid()"`
}

db.Save(&[]User{{Name: "name"}}

Does not rewrite to empty value, I tried other cases, and there is no difference from the current behavior (including the default value for built-in functions, such as gen_random_uuid() or now(), which usually do not need to set the value, but set the value will be overwritten, but this can only depend on how the user uses it).

cc @jinzhu

# Conflicts: # tests/create_test.go

daheige

LGTM!

Copilot

Pull Request Overview

This PR fixes an issue where fields with JSON default values were not being properly updated during upsert operations with OnConflict{UpdateAll: true}. The fix simplifies the logic in the OnConflict handler by removing an overly restrictive condition that was incorrectly filtering out columns that should be updated.

Key changes:

Simplified the OnConflict UpdateAll logic to include all non-primary-key columns in updates
Removed unnecessary condition checking for default values that was causing JSON fields with defaults to be skipped
Added test coverage for JSON default fields in both create and association scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
callbacks/create.go	Simplified OnConflict UpdateAll logic by removing the complex HasDefaultValue check and removed the now-unused strings import
tests/create_test.go	Fixed typo "OnConfilct" → "OnConflict" and added new test for OnConflict with JSON default values
tests/associations_test.go	Added test for FullSaveAssociations with JSON default values to verify the fix works with associations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T12:08:16Z

tests/associations_test.go

+
+	value.Dep.Params["foo"] = "new bar"
+	if err := DB.Session(&gorm.Session{FullSaveAssociations: true}).Save(&value).Error; err != nil {
+		t.Errorf("failed to svae value, got err: %v", err)


Corrected spelling of 'svae' to 'save'.

Suggested change

t.Errorf("failed to svae value, got err: %v", err)

t.Errorf("failed to save value, got err: %v", err)

fix: on confilct with default value

174cfc5

black-06 requested a review from a631807682 June 28, 2023 05:35

a631807682 approved these changes Jun 28, 2023

View reviewed changes

saeidee approved these changes Jul 3, 2023

View reviewed changes

Merge branch 'master' into create_on_confilct

6a03c28

a631807682 reviewed Jul 28, 2023

View reviewed changes

Merge branch 'master' into create_on_confilct

441092d

# Conflicts: # tests/create_test.go

daheige approved these changes Nov 7, 2024

View reviewed changes

wookie0 approved these changes Dec 31, 2024

View reviewed changes

jinzhu requested a review from Copilot October 30, 2025 12:06

Copilot AI reviewed Oct 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: on confilct with default value #6434

fix: on confilct with default value #6434

black-06 commented Jun 28, 2023 •

edited

Loading

jinzhu commented Jul 24, 2023

black-06 commented Jul 25, 2023 •

edited

Loading

black-06 commented Jul 25, 2023 •

edited

Loading

black-06 commented Jul 27, 2023

a631807682 commented Jul 27, 2023 •

edited

Loading

a631807682 left a comment •

edited

Loading

black-06 commented Jul 28, 2023

a631807682 commented Jul 28, 2023

black-06 commented Jul 28, 2023

a631807682 commented Jul 28, 2023

daheige left a comment

Copilot AI left a comment

Copilot AI Oct 30, 2025

Labels

6 participants

	t.Errorf("failed to svae value, got err: %v", err)
	t.Errorf("failed to save value, got err: %v", err)

Uh oh!

fix: on confilct with default value #6434

Are you sure you want to change the base?

fix: on confilct with default value #6434

Conversation

black-06 commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What did this pull request do?

User Case Description

jinzhu commented Jul 24, 2023

black-06 commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

black-06 commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

black-06 commented Jul 27, 2023

a631807682 commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

a631807682 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

black-06 commented Jul 28, 2023

a631807682 commented Jul 28, 2023

black-06 commented Jul 28, 2023

a631807682 commented Jul 28, 2023

daheige left a comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Labels

6 participants

black-06 commented Jun 28, 2023 •

edited

Loading

black-06 commented Jul 25, 2023 •

edited

Loading

black-06 commented Jul 25, 2023 •

edited

Loading

a631807682 commented Jul 27, 2023 •

edited

Loading

a631807682 left a comment •

edited

Loading