Fix marshaling of leading and trailing whitespace #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we can successfully marshal/unmarshal the value. One test now fails. I marked it as a failing test instead of trying to figure out how to fix it.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #792 +/- ##
==========================================
+ Coverage 77.97% 78.00% +0.03%
==========================================
Files 22 22
Lines 8108 8108
==========================================
+ Hits 6322 6325 +3
+ Misses 1370 1367 -3
Partials 416 416 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, please confirm the following.
Current go-yaml will marshal
map[string]string{"a": "\tvalue"}as"a: \tvalue"(that is, a literal tab character). Unmarshaling that producesmap[string]string{"a": "value"}instead of the original map.In addition to fixing leading tabs and leading newlines, I also changed
TestYAMLTestSuiteto round-trip every value to make sure that they can be properly marshaled and unmarshaled without changing the value. This uncovered several broken test cases. All but one are fixed by this PR, since that last one doesn't (primarily, at least) involve whitespace.