Closed
Description
I know this has been discussed before, but here's my thinking:
-
I suspect very few people, if any, use the
--logLevel infoflag to check for new deprecations. So we're effectively giving users a "6 releases from now" notice instead of a "12 releases from now" notice. I propose to start warning immediately, not after 6 releases. -
After 12 releases we're telling people we're going to remove the feature, but from their perspective it has already been removed. I propose to adjust the message as shown below.
diff --git a/common/hugo/hugo.go b/common/hugo/hugo.go
index eecf4bc2f..a1fe2b875 100644
--- a/common/hugo/hugo.go
+++ b/common/hugo/hugo.go
@@ -418,7 +418,7 @@ func Deprecate(item, alternative string, version string) {
func DeprecateLevel(item, alternative, version string, level logg.Level) {
var msg string
if level == logg.LevelError {
- msg = fmt.Sprintf("%s was deprecated in Hugo %s and will be removed in Hugo %s. %s", item, version, CurrentVersion.Next().ReleaseVersion(), alternative)
+ msg = fmt.Sprintf("%s was deprecated in Hugo %s and subsequently removed. %s", item, version, alternative)
} else {
msg = fmt.Sprintf("%s was deprecated in Hugo %s and will be removed in a future release. %s", item, version, alternative)
}
@@ -437,10 +437,8 @@ func deprecationLogLevelFromVersion(ver string) logg.Level {
case minorDiff >= 12:
// Start failing the build after about a year.
return logg.LevelError
- case minorDiff >= 6:
- // Start printing warnings after about six months.
- return logg.LevelWarn
default:
- return logg.LevelInfo
+ // Start warning immediately.
+ return logg.LevelWarn
}
}