Deploy, walkLocal performance #13817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
reviewed
Jun 25, 2025
deploy/deploy.go
Outdated
| for path := range jobs { | ||
| info, err := fs.Stat(path) | ||
| if err != nil { | ||
| errs <- err |
There was a problem hiding this comment.
I think the behaviour of the old code was to stop early on errors, and to me it makes sense to keep that.
Also see the para.Workers type in this repo that I think makes this pattern easier to read.
There was a problem hiding this comment.
Thanks! i've tried updating this now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose?
During hugo deploy we run
walkLocalwhich iterates over the filesystem. At larger scale deploys I've noticed this can be slow.This PR attempts to improve the performance by using a worker pool
Why?
To help improve deploy times
Example
Before my changes (just log changes)
After my changes
