-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
create/skeletons: Wrap section and home lists with section tags #14045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Neither
Use a |
|
@jmooring Hi, thanks for the reply!
I might be misunderstanding something, so can you please help me understand this better? Why are
and for
The |
|
Using an Go ahead and use |
But I am not wrapping I've updated title to |
Or to put it another way, don't use an |
c001ce5 to
5373d5e
Compare
|
Replaced |
|
Final step... please review the commit message guidelines. It should be something like: |
5373d5e to
c02ef77
Compare
Avoiding issues with tag leakage when using .Summary See issue gohugoio#14044 for details.
c02ef77 to
f186449
Compare
|
@jmooring I'm so sorry, missed that part when reading |
|
No problem, looks good, thank you for your contribution. |
|
Wanted to leave this research for the context, not for continuing the discussion After re-reading the spec and multiple articles 1, 2,3
I still think |
|
I have approved this PR as-is. I think we're done here. |
Yes, of course. As I've stated in the previous comment, I only intended to add some information after additional research, not to continue with the discussion. You are the "author" in the context of my previous comment, so your intent is what matters)) |
without this fix when the `.Summary` ends with blockquote it endsup swallowing next post as a part of blockquote formatting gohugoio/hugo#14044 gohugoio/hugo#14045 (comment) https://github.com/gohugoio/hugoDocs/pull/3230/files#diff-c06d7c00c7939481d14a2b74f72844be2e3759fdba9271e61f4f3a78ae6c7524R82-R83
Read more #14044