resources/page: Fix slugorcontentbasename for section pages #14126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
reviewed
Nov 10, 2025
resources/page/permalinks.go
Outdated
| // pageToPermalinkContentBaseName returns the URL-safe form of the content base name. | ||
| func (l PermalinkExpander) pageToPermalinkContentBaseName(p Page, _ string) (string, error) { | ||
| // For section pages (_index.md), return empty string to match the behavior of pageToPermalinkFilename | ||
| if l.translationBaseName(p) == "_index" { |
Member
There was a problem hiding this comment.
I think you can do p.PathInto().IsBranchBundle and get a slightly cleaner setup.
Contributor
Author
There was a problem hiding this comment.
Thanks, updated to use p.PathInfo().IsBranchBundle() along with p.File() != nil to handle sections without files
The slugorcontentbasename permalink token was creating an extra subdirectory for section pages (_index.md files). This was because pageToPermalinkContentBaseName did not have the same special handling for _index.md files as pageToPermalinkFilename. This commit adds the special handling to return an empty string for section pages, ensuring backward compatibility with slugorfilename. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Fixes gohugoio#14104
dvdksn
force-pushed
the
fix-slugorcontentbasename-section-pages
branch
from
650099b to
c483799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
slugorcontentbasenamepermalink token creating an extra subdirectory for section pages (_index.mdfiles).Problem
When using
slugorcontentbasenamein permalinks for section pages, an extra subdirectory was created. For example:With content at
content/foo/bar/_index.md, this would generate/bar/bar/index.htmlinstead of the expected/bar/index.html.The deprecated
slugorfilenametoken worked correctly by returning an empty string for_index.mdfiles.Solution
Added special handling in
pageToPermalinkContentBaseNameto return an empty string for section pages (_index.mdfiles), matching the behavior ofpageToPermalinkFilename.Testing
TestIssue14104to verify the fix🤖 Generated with Claude Code
Fixes #14104