create: Prevent panic when content file exists with different case #14256
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "hugo new" is run and a file with the same name but different case already exists (e.g. Floop.md vs floop.md), Hugo previously panicked in applyArchetype because the internal page lookup is case-sensitive. Add a case-insensitive directory check before writing the placeholder file and return a clear error when a conflict is found. The --force flag continues to overwrite exact matches (existing behaviour) and will still panic on pure case-conflicts (also existing behaviour). Fixes gohugoio#14112 Signed-off-by: Tharun V S <tharunvs777@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14112
– prevents the panic in hugo new when a content file exists with different case only.
Adds a small case-insensitive check in CreateContentPlaceHolder and returns a clear error instead of panicking.
--force behaviour is intentionally unchanged (still panics on pure case-conflicts).
mage -v check and mage hugoRace pass.