Skip to content

Conversation

@sprig
Copy link
Contributor

@sprig sprig commented Mar 11, 2016

This change would allow one to pick a specific file to embed out of a multifile gist.

@CLAassistant
Copy link

CLA assistant check
All committers have accepted the CLA.

@moorereason
Copy link
Contributor

Please update docs/content/extras/shortcodes.md

@sprig
Copy link
Contributor Author

sprig commented Mar 11, 2016

done.

@moorereason
Copy link
Contributor

lgtm

@bep
Copy link
Member

bep commented Mar 11, 2016

Looks good to me, too. Could you squash the 3 commits into one?

@sprig
Copy link
Contributor Author

sprig commented Mar 11, 2016

Done.

@bep
Copy link
Member

bep commented Mar 11, 2016

Could you also fix the commit message (see guidelines).

@sprig
Copy link
Contributor Author

sprig commented Mar 11, 2016

I hope this is better?

@bep
Copy link
Member

bep commented Mar 11, 2016

"better" is subjective, but it is correct.

@bep
Copy link
Member

bep commented Mar 11, 2016

Merged in e9008b9 thanks for the contrib.

@bep bep closed this Mar 11, 2016
@sprig
Copy link
Contributor Author

sprig commented Mar 11, 2016 via email

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

4 participants