Fixing Google Analytics Tracking

[hugoovf]

No description provided.

[CLAassistant]

All committers have signed the CLA.

[davidsneighbour]

What does this "fix"? It tracks when donottrack is set and if it is not set it does not track. It literally breaks the functionality.

[hugoovf]

I "true" want to don't be tracked, the script will be executed.
I "false" want to don't be tracked, script won't be executed.

[hugoovf]

We're being anonymized when donottrack is true, or do I have the wrong point of view?

#8264 (comment)

[davidsneighbour]

I think you are wrong. The code you changed is "is donottrack disabled? then do track". The code that section creates is the initial adding of the tracking script, not about the browser feature do not track. Its basically a security setting so site owners can override the themes setup. It's the question if the site config disables google analytics.

Have a read through this section:

https://gohugo.io/about/security-model/#security-policy

I would think there were more issues open about this, as in avalanche, if this would be wrongly implemented.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.