Fix Plainify edge cases #9923
Merged
Fix Plainify edge cases #9923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
fix/plainify-9909-9410
branch
2 times, most recently
from
2d44562 to
0b15fc9
Compare
This commit replaces the main part of `helpers.StripHTML` with Go's implementation in its html/template package. It's a little slower, but correctness is more important: ```bash BenchmarkStripHTMLOld-10 680316 1764 ns/op 728 B/op 4 allocs/op BenchmarkStripHTMLNew-10 384520 3099 ns/op 2089 B/op 10 allocs/op ``` Fixes gohugoio#9199 Fixes gohugoio#9909 Closes gohugoio#9410
bep
force-pushed
the
fix/plainify-9909-9410
branch
from
0b15fc9 to
ff37b1c
Compare
Member
Author
|
I also compared this branch against the #9923 name old time/op new time/op delta
StripHTML-10 3.19µs ± 5% 16.28µs ± 4% +410.24% (p=0.029 n=4+4)
name old alloc/op new alloc/op delta
StripHTML-10 2.07kB ± 0% 13.44kB ± 0% +548.34% (p=0.029 n=4+4)
name old allocs/op new allocs/op delta
StripHTML-10 10.0 ± 0% 163.0 ± 0% +1530.00% (p=0.029 n=4+4) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Plainify edge cases
This commit replaces the main part of
helpers.StripHTMLwith Go's implementation in its html/template package.It's a little slower, but correctness is more important:
Fixes ##9199
Fixes #9909
Closes #9410