This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Merged
Conversation
github-actions
bot
added
status:awaiting review
Contributor
|
this can break someone's code if they are using 5 for NOT_EQUAL and 6 for EXCLUDES as per the last code. I may be wrong. |
Collaborator
Author
|
Normally yes, you wouldn't change enum values. But this PR fixes it so the integer values match how the API interprets them. It's possible this breaks someone, but this code has low usage (We've never provided an example of how to use this yet). I don't want to keep it out of sync with the API just for consistency with an old version. Right now if you serialize an proto that includes one of these enum values, then convert the json back to a proto the result will be different. |
shilpakancharla
approved these changes
Jul 3, 2024
github-actions
bot
removed
the
status:awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #411