Skip to content

Conversation

@zchee
Copy link
Contributor

@zchee zchee commented Nov 13, 2025

Modernize.

$ go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
$ go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zchee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the codebase by updating various Go constructs to leverage newer language features and standard library packages. The changes aim to improve code readability, conciseness, and potentially efficiency by adopting any as an alias for interface{}, utilizing functions from the maps and slices packages, and employing more modern string manipulation and loop syntaxes.

Highlights

  • Go any Type Alias Adoption: Replaced instances of map[string]interface{} with map[string]any for improved readability and adherence to modern Go practices, leveraging the any type alias introduced in Go 1.18.
  • Modern maps Package Usage: Introduced and utilized functions from the maps package, specifically maps.Copy for efficient map copying and maps.Collect for collecting map elements, replacing manual iteration loops.
  • Modern slices Package Usage: Adopted slices.Contains for checking membership within a slice, simplifying conditional logic and improving code clarity.
  • Efficient String Prefix Handling: Replaced the combination of strings.HasPrefix and strings.TrimPrefix with the more concise and efficient strings.CutPrefix function.
  • Idiomatic Loop Syntax: Updated for loops where the iteration variable was unused from for i := 0; i < N; i++ to the more idiomatic for range N.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request applies automated modernizations to the Go codebase using gopls modernize. The changes are beneficial, improving code readability and aligning it with modern Go idioms. Key changes include adopting any over interface{}, using helper functions from the maps and slices packages like Copy, Collect, and Contains, replacing some loops with for range N, and using strings.CutPrefix. All modifications are correct and improve the codebase. This PR is good to merge.

Copy link
Member

@rakyll rakyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rakyll rakyll merged commit 7a27c16 into google:main Nov 14, 2025
1 check passed
@zchee zchee deleted the modernize-2025-11-14 branch November 14, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants