Skip to content

Rebase to alpine 3.22, install thin-provisioning-tools from main repo #3705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aptalca
Copy link

@aptalca aptalca commented Jun 18, 2025

This PR rebases the build and runtime base images to the latest stable Alpine 3.22. Golang version is still the same 1.24. It also installs thin-provisioning-tools from the 3.22 repo instead of edge.

It looks like thin-provisioning-tools was being installed from the edge repo 5 years ago, presumably because at the time the edge repo contained a newer version that was required. At this point the edge repo contains the same exact version as the 3.22 repo so there is no need to install from edge.

Plus, installing packages from the edge repo is usually not recommended unless absolutely necessary. Even then, the base version needs to be recent enough to prevent dep clashes. Currently, the base image used is still 3.18, which is several years old. Edge on the other hand is a rolling branch, so it is trying to install a brand new package on a base from several years ago, which is not an ideal situation.

It looks like thin-provisioning-tools was being installed from the edge repo 5 years ago, presumably because at the time the edge repo contained a newer version that was required.
At this point the edge repo contains the same exact version as the 3.22 repo so there is no need to install from edge.
Copy link

google-cla bot commented Jun 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant