Merged
Conversation
chalin
reviewed
May 27, 2025
9 tasks
Collaborator
|
For the record, if we ignore the changes to $ (cd public && git diff -bw --ignore-blank-lines) | grep -Ev '_print|\.xml$|\.map$' | grep ^diff | grep -v '^diff --git a/no'
diff --git a/js/main.js b/js/main.js
diff --git a/scss/main.css b/scss/main.css
diff --git a/scss/main.rtl.css b/scss/main.rtl.css |
chalin
reviewed
May 27, 2025
Collaborator
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Thanks for the updates. Doesn't this PR also need the following?
$ git diff
diff --git a/go.sum b/go.sum
index 3ed3add..8a42dcd 100644
--- a/go.sum
+++ b/go.sum
@@ -1,4 +1,6 @@
+github.com/FortAwesome/Font-Awesome v0.0.0-20241216213156-af620534bfc3 h1:/iluJkJiyTAdnqrw3Yi9rH2HNHhrrtCmj8VJe7I6o3w=
github.com/FortAwesome/Font-Awesome v0.0.0-20241216213156-af620534bfc3/go.mod h1:IUgezN/MFpCDIlFezw3L8j83oeiIuYoj28Miwr/KUYo=
github.com/google/docsy v0.12.0 h1:CddZKL39YyJzawr8GTVaakvcUTCJRAAYdz7W0qfZ2P4=
github.com/google/docsy v0.12.0/go.mod h1:1bioDqA493neyFesaTvQ9reV0V2vYy+xUAnlnz7+miM=
+github.com/twbs/bootstrap v5.3.6+incompatible h1:efmXVyq839m5QQ0+JBUdQQ1TrmoBqvQ5kRhUueKsH+4=
github.com/twbs/bootstrap v5.3.6+incompatible/go.mod h1:fZTSrkpSf0/HkL0IIJzvVspTt1r9zuf7XlZau8kpcY0=
Collaborator
|
@deining - btw, there is more to be done after this PR gets merged, and before we cut release 0.12.0 of the example. See: |
Contributor
Author
Added these two lines, as requested. |
Contributor
Author
|
The heading render hooks was now moved to its correct place according to the new template system. |
chalin
approved these changes
May 27, 2025
Collaborator
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
LGTM. (Haven't double checked if all hard coded Docsy and Hugo versions have been updated, but I'll trust that you were thorough.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps docsy theme to latest released version
v0.12.0.