Breadcrumbs: restore Aria attribute and link#1068
Merged
LisaFC merged 1 commit intogoogle:mainfrom Jun 24, 2022
Merged
Conversation
Collaborator
|
LGTM! |
Contributor
|
@chalin May be a bit late as this has already been merged, but does it make sense to have Agree with the use of aria-disabled and disabled links, thanks for fixing that. |
Collaborator
Author
|
As I mentioned elsewhere, I think that all ARIA attributes should be removed in that case. Let's move this discussion to #1071. |
fekete-robert
pushed a commit
to fekete-robert/docsy
that referenced
this pull request
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the changes to the breadcrumb partial done in #1011. In particular, this PR:
In #1011, @at055612 notes that:
I agree on both points, and ( propose the following (which feels like a win-win): ensure that all breadcrumbs are links, but effectively disable the last breadcrumb. I use Bootstrap's
disabledclass and the Aria aria-disabled attribute. The documentation for aria-disabled explicitly mentions as a use case the situation of a link/button to a self.Visually, you'll see no difference, e.g.:
Preview: for example see https://deploy-preview-1068--docsydocs.netlify.app/docs/get-started/docsy-as-module/
Note that while the last breadcrumb is disabled, its link can still be visited.