Ensure a Page always has a Title #1161
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pages without Frontmatter for `title` or `linkTitle` result in empty entries in the sidebar and list pages. This partial provides additional fallback Titles based on the Content H1 or File name, which can replace use in multiple templates where `$s.linkTitle` is hardcoded
Collaborator
|
I like this idea! Do you have any examples of what a title pulled from the file name would look like? We should also document this behaviour in the user guide, maybe with a small update to the (increasingly enormous) Navigation and Search page: |
chalin
reviewed
Aug 15, 2022
Collaborator
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Interesting. We started discussing this during the PSC meeting today. I have a few potential concerns which I'll share a little later. (Marking this as draft in the meantime to ensure it doesn't get inadvertently merged.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pages without Frontmatter for
titleorlinkTitleresult in empty entries in the sidebar and list pages.This partial provides additional fallback Titles based on the Content H1 or File name, which can replace use in multiple templates where
$s.linkTitleis hardcoded