Fix: mermaid diagrams with parameters in site config#1316
Merged
geriom merged 1 commit intogoogle:mainfrom Dec 1, 2022
Merged
Conversation
deining
force-pushed
the
mermaid-regression
branch
from
955edaa to
dfcfcf8
Compare
deining
force-pushed
the
mermaid-regression
branch
from
dfcfcf8 to
aa84320
Compare
multun
approved these changes
Nov 26, 2022
geriom
approved these changes
Dec 1, 2022
Collaborator
geriom
left a comment
geriom
left a comment
There was a problem hiding this comment.
Tested and can confirm this works. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes this two regressions introduced with 90843e3:
mermaid.enable=truewas given. With auto-activation of mermaid diagrams in place, parameters should be considered event ifmermaid.enableis missing in the site config.This PR also bumps mermaid to the latest released version 9.2.2.