Skip to content

prevent navbar text wrapping#1320

Merged
geriom merged 1 commit intogoogle:mainfrom
osrd-project:fix-navbar-wrapping
Dec 2, 2022
Merged

prevent navbar text wrapping#1320
geriom merged 1 commit intogoogle:mainfrom
osrd-project:fix-navbar-wrapping

Conversation

@multun
Copy link
Contributor

@multun multun commented Nov 25, 2022

When a navbar item has multiple words, and there are enough navbar item to cause the flexbox to be full at reduced window widths without transitioning through the lower media breakpoint, the navbar link name can wrap, which causes the alignment of all navbar items to break.

This change forbids navbar text wrapping even at bigger screen sizes.
geriom
geriom approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@geriom
Copy link
Collaborator

geriom commented Dec 1, 2022

@multun It seems I can't push changes to your branch. Please rebase to include the latest changes from main so we can merge.
@multun
prevent navbar text wrapping
5fa9b9d 
When a navbar item has multiple words, and there are enough navbar item to
cause the flexbox to be full at reduced window widths without transitioning
through the lower media breakpoint, the navbar link name can wrap, which causes
the alignment of all navbar items to break.

This change forbids navbar text wrapping even at bigger screen sizes.
@multun
Copy link
Contributor Author

multun commented Dec 2, 2022

@geriom done
@geriom geriom merged commit 1fb0e23 into google:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@multun @geriom