Adding shortcode for accordion component (Bootstrap 5) #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deining
force-pushed
the
bs-accordion
branch
from
74a6cd7 to
f9ffe80
Compare
|
the Collapse component too! https://getbootstrap.com/docs/5.2/components/collapse/ |
deining
force-pushed
the
bs-accordion
branch
from
e8670f4 to
82ee61b
Compare
aimeeu
reviewed
Nov 22, 2023
Contributor
aimeeu
left a comment
aimeeu
left a comment
There was a problem hiding this comment.
Thank you for implementing this! I left a few nits on the user guide text.
deining
force-pushed
the
bs-accordion
branch
from
e653353 to
2196693
Compare
Contributor
Author
You are welcome!
Thanks for your review and your helpful comments. All proposed changes are incorporated now. |
|
@deining would you have capacity to update this in light of changes to main? |
deining
force-pushed
the
bs-accordion
branch
from
c8882b5 to
68be2e3
Compare
Contributor
Author
I rebased my PR as requested. Everything is still working AFAICS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two shortcodes
accordionandaccordion-itemin order to allow authoring of a accordion components. You will encounter this element frequently on various websites, e.g. for FAQ sections. The markup for an accordion is similar to the markup for creating a tabbed pane. For a preview have a look at the implementation details and the documentation given here:https://deploy-preview-1391--docsydocs.netlify.app/docs/adding-content/shortcodes/#accordion
This PR makes use of the accordion component introduced with bootstrap 5.
I hope you like the feature.