Skip to content

Feature Block Update #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
H20220009 wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Feature Block Update #1396

H20220009 wants to merge 13 commits into from

Conversation

@H20220009
Copy link

@H20220009 H20220009 commented Feb 6, 2023

I made all the necessary changes as asked in feature request #1241.
I hope it resolves that problem.
Please let me know if any other changes are needed.
@H20220009 H20220009 mentioned this pull request Feb 7, 2023
Open
deining
deining suggested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my two review comments. Thanks.
@deining deining added the shortcodes Hugo shortcodes label Feb 8, 2023
@H20220009 H20220009 requested a review from deining February 15, 2023 14:10
@H20220009
Copy link
Author

H20220009 commented Feb 19, 2023

@deining
Please review the changes, I have made all the necessary changes as asked by you on both places.
deining
deining suggested changes Feb 27, 2023
View reviewed changes
deining
deining suggested changes Feb 27, 2023
View reviewed changes
@H20220009
Copy link
Author

H20220009 commented Mar 28, 2023

@deining
Please review the changes. I have made all the necessary changes as asked in both places.
@H20220009 H20220009 requested a review from deining March 28, 2023 08:13
deining
deining suggested changes Mar 31, 2023
View reviewed changes
@H20220009 H20220009 requested a review from deining April 1, 2023 06:19
@H20220009
Copy link
Author

H20220009 commented Apr 14, 2023

@deining
Please review the changes. I have made all the necessary changes as asked.
@H20220009
Copy link
Author

H20220009 commented Apr 20, 2023

@emckean @chalin @deining
Can you please review this PR? It is solving issue #1241
@H20220009
Copy link
Author

H20220009 commented Apr 24, 2023

@deining
Please review the changes. I have made all the necessary changes as asked.
@emckean @chalin
Can you please review this PR? It is solving issue #1241
H20220009 added 9 commits May 31, 2023 10:49
@H20220009 @chalin
Update feature.html
8667240
@H20220009 @chalin
Update feature.html
1025470
@H20220009 @chalin
Update feature.html
e83e5f4 
As the changes were requested, I used With function so that link is applied only when the URL is given
@H20220009 @chalin
Update feature.html
29aed21 
As asked I had written the code so that it will generate valid markup in both cases that is whether the "URL"  is included or not.
@H20220009 @chalin
Update feature.html
8f34f43
@H20220009 @chalin
Update feature.html
188409b
@H20220009 @chalin
Update feature.html
a47107f
@H20220009 @chalin
Update feature.html
378a40d
@H20220009 @chalin
Update feature.html
9b00f22
@chalin chalin added this to the 23Q3 milestone Jun 2, 2023
@chalin chalin modified the milestones: 23Q3, 23Q4 Jul 27, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Nov 3, 2023
@chalin chalin modified the milestones: 24Q1, 24Q2 Jan 11, 2024
@chalin chalin modified the milestones: 24Q2, 24Q3 Apr 2, 2024
@chalin chalin modified the milestones: 24Q3, 24Q4 Jul 2, 2024
@chalin chalin modified the milestones: 24Q4, 25Q1 Oct 3, 2024
@chalin chalin modified the milestones: 25Q1, 25Q2 Jan 7, 2025
@chalin chalin modified the milestones: 25Q2, 25Q3 Aug 2, 2025
@chalin chalin removed this from the 25Q3 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shortcodes Hugo shortcodes

3 participants

@H20220009 @deining @chalin