-
Notifications
You must be signed in to change notification settings - Fork 956
Change navbar search border colour to make it stand out #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I like it, though I wonder should we make it an option rather than the default? Anyone else? |
|
I've also changed the lookout from this search input in our docs a little bit. You can have a look at this test page: This example has 3 changes to the current official version:
The version of @at055612 is also OK for me and in my opinion better the the current search input. I would make it as Docsy default if you merge it. |
|
I like them both but I think I like @narrenfrei's version slightly better. Anyone else? |
|
I'm happy with @narrenfrei's version. A bit more subtle. As long as the border can be seen I am ok. |
Jassi10000-zz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@at055612
Buddy you must resolve the merge conflicts before you make a PR
The PR was not in conflict when created. It is now but I was waiting on a decision from the maintainers whether to proceed with this PR or for @narrenfrei's change to be used instead. |
|
My vote is to preserve the current default. Projects can easily customize this to their own tastes. |
|
The new version of Algolia has different styling for the search box that makes it stand out by default. |
Currently the navbar search input has border
noneso you just see a hint of the drop shadow. As the input text is shorter than the input it looks like there is a lot of empty space to the right of it.Before the change it looks like
After the change it looks like