Skip to content

Conversation

@at055612
Copy link
Contributor

Currently the navbar search input has border none so you just see a hint of the drop shadow. As the input text is shorter than the input it looks like there is a lot of empty space to the right of it.

Before the change it looks like

image

After the change it looks like

image

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 16, 2021
@LisaFC
Copy link
Collaborator

LisaFC commented Jul 16, 2021

I like it, though I wonder should we make it an option rather than the default? Anyone else?

@narrenfrei
Copy link
Contributor

I've also changed the lookout from this search input in our docs a little bit. You can have a look at this test page:
https://60f2abac014e3400078b4632--sad-volhard-b41b3b.netlify.app

This example has 3 changes to the current official version:

  1. make the search input a little bit more visable
  2. let the placeholder visible until typing in something (like in the sidebar)
  3. give the language dropdown in the sidebar (on smaller devices) a little bit more padding

The version of @at055612 is also OK for me and in my opinion better the the current search input. I would make it as Docsy default if you merge it.

@LisaFC
Copy link
Collaborator

LisaFC commented Jul 21, 2021

I like them both but I think I like @narrenfrei's version slightly better. Anyone else?

@at055612
Copy link
Contributor Author

I'm happy with @narrenfrei's version. A bit more subtle. As long as the border can be seen I am ok.

Copy link

@Jassi10000-zz Jassi10000-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@at055612
Buddy you must resolve the merge conflicts before you make a PR

@at055612
Copy link
Contributor Author

at055612 commented Feb 2, 2022

@at055612 Buddy you must resolve the merge conflicts before you make a PR

The PR was not in conflict when created. It is now but I was waiting on a decision from the maintainers whether to proceed with this PR or for @narrenfrei's change to be used instead.

@chalin chalin added the design/style Front-end site design / styling label Feb 2, 2022
@chalin
Copy link
Collaborator

chalin commented Feb 2, 2022

My vote is to preserve the current default. Projects can easily customize this to their own tastes.

@prdsoftware
Copy link

The new version of Algolia has different styling for the search box that makes it stand out by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. design/style Front-end site design / styling

6 participants