Add support for Bootstrap and FontAwesome via NPM packages#904
Merged
chalin merged 3 commits intogoogle:masterfrom Feb 22, 2022
Merged
Conversation
Collaborator
chalin
commented
Feb 22, 2022
chalin
commented
- This is a version of Drop Bootstrap and Font Awesome git submodules #889 that doesn't remove the git submodules, and hence isn't a breaking change.
- Closes Use NPM packages for Bootstrap and Font Awesome #870
- Add FA npm package @5.15.4 - Add bootstrap@4.6.1 - Edit NPM scripts: drop submodule scripts
chalin
force-pushed
the
chalin-bs-and-fa-via-npm-non-brk-2022-02-21
branch
from
dd646bd to
7b4c15e
Compare
Collaborator
Author
|
I've tested this on one of our projects, and I'm able to use this PR w/o it being a breaking change. Projects can continue to use docsy via a git module with or without recursive submodule dependencies. To use docsy dependencies via NPM packages one needs to:
From this point on, build the project as you did before. |
Collaborator
Author
|
Since this isn't a breaking change, and since #889 (of which this PR is a subset) was approved, I'm going to merge this PR. |
Collaborator
Author
|
The production build is now using BS + FA via NPM packages: For details, see the log: https://app.netlify.com/sites/docsydocs/deploys/6214f1b914a72c0007d91062#L105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.