Fix: Resolve pylint naming convention warnings in provider modules#273
Merged
Fix: Resolve pylint naming convention warnings in provider modules#273
Conversation
- Rename module-level variables from _UPPERCASE to _lowercase - Add pylint disable comments for CI compatibility - Variables are not constants as they're modified at runtime
aksg87
force-pushed
the
fix-pylint-provider-issues
branch
from
ae4a16a to
09466aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_UPPERCASEto_lowercasesnake_caseDetails
The CI was failing with pylint errors about variable naming conventions:
_ENTRIESand_ENTRY_KEYSin router.py_PLUGINS_LOADEDand_BUILTINS_LOADEDin init.pyThese are module-level private variables that get modified at runtime (not constants), so they should follow snake_case convention per PEP-8.
Testing
tox -e lint-src