Initial Sigma support #1028
Merged
Initial Sigma support #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � timesketch/lib/analyzers/__init__.py � timesketch/lib/analyzers/sigma_tagger.py � timesketch/lib/analyzers/sigma_tagger_test.py
berggren
requested changes
Nov 13, 2019
Closed
berggren
previously approved these changes
Jan 10, 2020
|
@Onager Seeing that sigmatools is py3 only, it fails (naturally) when run on py2. Until we remove py2 support we need to check for this in the tests, and also not register the analyzer if run on py2. When this is fixed this one is ready to merge. |
|
This is a good oppurtunity to sunset py2 support. I'll do that in another PR before merging this one. |
berggren
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work for Sigma integration.
Adding more mappings would be ongoing work, to make analyzer compatible with different rulesets. I can add more tests in a follow up PR, once some of the analyzer testing code is complete/merged.