Skip to content

Datastore: expose 'reserveIds' API. - #8178

Merged
tseaver merged 5 commits into
googleapis:masterfrom
HemangChothani:feature/datastore_expose_reserveIds
Jun 4, 2019
Merged

Datastore: expose 'reserveIds' API.#8178
tseaver merged 5 commits into
googleapis:masterfrom
HemangChothani:feature/datastore_expose_reserveIds

Conversation

@HemangChothani

@HemangChothani HemangChothani commented May 27, 2019

Copy link
Copy Markdown
Contributor

Fixes: #7111
@HemangChothani
HemangChothani requested a review from crwilcox as a code owner May 27, 2019 13:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2019
tseaver
tseaver suggested changes May 28, 2019
View reviewed changes

@tseaver tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!
Comment thread datastore/tests/unit/test_client.py Outdated
Comment thread datastore/tests/unit/test_client.py Outdated
Comment thread datastore/tests/unit/test_client.py Outdated
Comment thread datastore/tests/unit/test_client.py Outdated
Comment thread datastore/tests/unit/test_client.py Outdated
Comment thread datastore/google/cloud/datastore/client.py Outdated
Comment thread datastore/google/cloud/datastore/client.py Outdated
Comment thread datastore/google/cloud/datastore/client.py Outdated
Comment thread datastore/tests/unit/test_client.py Outdated
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2019
@tseaver

tseaver commented May 28, 2019

Copy link
Copy Markdown
Contributor

Also, per line #117 of the Kokoro job for Datastore, please run nox -re black to appease the linter.
@tseaver tseaver changed the title Datastore: Fix expose 'reserveIds' at top level. May 29, 2019
@tseaver

tseaver commented May 29, 2019

Copy link
Copy Markdown
Contributor

@HemangChothani Please don't mark a reviewer's requested changes as "resolved" until you've pushed the commit which adds the change. If you address the review comment by commenting back, let the reviewer mark it as resolved if she / he agrees with your reply.
@sduskis sduskis added the api: datastore Issues related to the Datastore API. label May 30, 2019
tseaver
tseaver reviewed Jun 3, 2019
View reviewed changes
Comment thread datastore/tests/unit/test_client.py Outdated
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 4, 2019
@tseaver

tseaver commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

The BigQuery Kokoro failure is unrelated (see #8212).
@tseaver
tseaver merged commit 79b1024 into googleapis:master Jun 4, 2019
parthea pushed a commit that referenced this pull request Nov 24, 2025
@HemangChothani @tseaver
Add 'Client.reserve_ids' API wrapper. (#8178)
2915065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

6 participants

@HemangChothani @tseaver @sduskis @googlebot @yoshi-automation @yoshi-kokoro