Skip to content

Speech: Add speaker diarization configuration support (via synth). - #9202

Merged
busunkim96 merged 1 commit into
googleapis:masterfrom
tseaver:9196-speech-manual-synth
Sep 10, 2019
Merged

Speech: Add speaker diarization configuration support (via synth).#9202
busunkim96 merged 1 commit into
googleapis:masterfrom
tseaver:9196-speech-manual-synth

Conversation

@tseaver

@tseaver tseaver commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.

Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
@tseaver tseaver added api: speech Issues related to the Speech-to-Text API. codegen labels Sep 10, 2019
@tseaver
tseaver requested a review from busunkim96 as a code owner September 10, 2019 17:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2019
@tseaver

tseaver commented Sep 10, 2019

Copy link
Copy Markdown
Contributor Author

@busunkim96 This PR and #9201 assume that just excluding noxfile.py from the synth copy process is correct for language and speech (so that the samples stanza remains). Would re rather add a samples section to the generator?

The current implementation:

  • skips the stanza if the samples directory is missing;
  • tests the samples using sample-tester
@busunkim96

Copy link
Copy Markdown
Contributor

@tseaver I should probably add the samples session to the noxfile template eventually. This is fine for now.

@busunkim96
busunkim96 merged commit 7da4a40 into googleapis:master Sep 10, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 11, 2019
…s#9202)

Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes googleapis#9196.
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
…s#9202)

Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes googleapis#9196.
atulep pushed a commit that referenced this pull request Apr 3, 2023
Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
atulep pushed a commit that referenced this pull request Apr 6, 2023
Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
atulep pushed a commit that referenced this pull request Apr 18, 2023
Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
parthea pushed a commit that referenced this pull request Oct 22, 2023
Also, exclude 'noxfile.py' from synth (to preserve 'samples').

Supersedes #9196.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement. codegen

3 participants