FIX: GCS Bucket subdirectory not being creating while using ReasoningEngine create method #3651
Closed
ItsMeAbby wants to merge 3 commits into
Closed
FIX: GCS Bucket subdirectory not being creating while using ReasoningEngine create method #3651ItsMeAbby wants to merge 3 commits into
ItsMeAbby wants to merge 3 commits into
Conversation
Earlier blobs subfolder were created using
blob = gcs_bucket.blob(os.path.join(gcs_dir_name, _EXTRA_PACKAGES_FILE))
which resulted in files with name like gcs_dir_name\_EXTRA_PACKAGES_FILE instead of creating folder.
now fixed it with blob = gcs_bucket.blob(f"{gcs_dir_name}/{_EXTRA_PACKAGES_FILE}")
this creates a sub folder
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
Bot
added
size: xs
yeesian
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
yeesian
added
ready to pull
yeesian
approved these changes
Apr 24, 2024
yeesian
approved these changes
Apr 25, 2024
yeesian
approved these changes
Apr 25, 2024
sasha-gitg
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3650 🦕
Earlier blobs subfolder were created using
blob = gcs_bucket.blob(os.path.join(gcs_dir_name, _EXTRA_PACKAGES_FILE))
which resulted in files with name like gcs_dir_name_EXTRA_PACKAGES_FILE instead of creating folder.
now fixed it with blob = gcs_bucket.blob(f"{gcs_dir_name}/{_EXTRA_PACKAGES_FILE}")
this creates a sub folder
This fixes the issue
404 Can not copy from "gs://aretec-vertex-lc-stagging/reasoning_engine/reasoning_engine.pkl" to "gs://1006586376595-996210311323189248-1713810220200/code.pkl", check if the source object and target bucket exist.