Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

feat: Add support for google.cloud.ndb.__version__ - #929

Merged
parthea merged 1 commit into
mainfrom
add-version-module
Nov 24, 2023
Merged

feat: Add support for google.cloud.ndb.__version__#929
parthea merged 1 commit into
mainfrom
add-version-module

Conversation

@parthea

@parthea parthea commented Nov 22, 2023

Copy link
Copy Markdown
Contributor

This PR migrates from using a hardcoded version in setup.py to a version module to make it easy to query the current version of google-cloud-ndb

(py39) partheniou@partheniou-vm-3:~/git/python-ndb$ python3
Python 3.9.16 (main, Mar  2 2023, 17:52:22) 
[GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import google.cloud.ndb
>>> google.cloud.ndb.__version__
'2.2.2'
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Nov 22, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2023
@parthea
parthea marked this pull request as ready for review November 24, 2023 19:09
@parthea
parthea requested review from a team November 24, 2023 19:09
@parthea
parthea marked this pull request as draft November 24, 2023 19:15
@parthea
parthea force-pushed the add-version-module branch 2 times, most recently from 1535c86 to e2a03d8 Compare November 24, 2023 19:20
@parthea parthea changed the title feat: add support for google.cloud.ndb.__version__ Nov 24, 2023
@parthea
parthea marked this pull request as ready for review November 24, 2023 20:07
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2023
@parthea

parthea commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

@rwhogg Please could you review?
bw-yuhogg
bw-yuhogg reviewed Nov 24, 2023
View reviewed changes

@bw-yuhogg bw-yuhogg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@parthea
parthea merged commit 42b3f01 into main Nov 24, 2023
@parthea
parthea deleted the add-version-module branch November 24, 2023 20:28
@release-please release-please Bot mentioned this pull request Nov 24, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API.

2 participants

@parthea @bw-yuhogg