converter: use backticks in generated alloy for strings #3715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalleep
commented
May 28, 2025
| @@ -1,6 +1,6 @@ | |||
| otelcol.receiver.otlp "default" { | |||
| grpc { | |||
| endpoint = coalesce(sys.env("NORMAL_FORMAT"), "https://www.example.com/some/file-path?query={using brackets, spaces,+'and'%20\"quotes\"}") | |||
| endpoint = `${env:NORMAL_FORMAT:-https://www.example.com/some/file-path?query={using brackets, spaces,+'and'%20"quotes"}}` | |||
There was a problem hiding this comment.
this is not correct
|
This PR has not had any activity in the past 30 days, so the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
If we detect any double quotes we use backticks for generated string
Which issue(s) this PR fixes
Fixes: 3690
Notes to the Reviewer
PR Checklist