Skip to content

ci: stop using windows-2019 runners #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zerok
Copy link

@zerok zerok commented Jun 2, 2025

The windows-2019 runners are deprecated as of 2025-06-01 and will be fully unsupported by 2025-06-30. There will be multiple brown-outs over the course of this month which might affect builds and releases unless we remove those runners.

See actions/runner-images#12045 for details.

The windows-2019 runners are deprecated as of 2025-06-01 and will be
fully unsupported by 2025-06-30. There will be multiple brown-outs over
the course of this month which might affect builds and releases unless
we remove those runners.

See actions/runner-images#12045 for details.
@zerok zerok requested a review from a team as a code owner June 2, 2025 07:51
@CLAassistant
Copy link

CLAassistant commented Jun 2, 2025

CLA assistant check
All committers have signed the CLA.

@zerok
Copy link
Author

zerok commented Jun 2, 2025

Unfortunately I have no idea if this affects the releases themselves but since the binaries are built using just the Go toolchain I'm hoping this is fine 🙂

@ptodev
Copy link
Contributor

ptodev commented Jun 16, 2025

Hi @zerok, thank you for the PR! I think it would be ok to merge it as long as it has a changelog entry. Would you mind adding one please?

It's not ideal remove that container since normally Alloy supports all OS versions officially supported by the OS vendor. Windows 2019 will still be supported until 2029. That said, it's probably not a huge issue because if a user is using containers then they are probably good at updating their OS 😅 Alloy itself will still work on Windows 2019 even though we won't distribute a container image.

@ptodev ptodev self-assigned this Jun 16, 2025
@ptodev
Copy link
Contributor

ptodev commented Jun 16, 2025

@zerok Oh wait I just realised that tools/ci/docker-containers-windows uses the nanoserver:ltsc2019 base image when running on the Windows 2025 build server. Now your comment makes sense. It'd be good to make sure we can really run this container on Windows 2019... I'll see if I can test this somehow.

@ptodev
Copy link
Contributor

ptodev commented Jun 27, 2025

Unfortunately, it's not possible to build images for Windows 2019 on new versions of Windows like this. Docker needs the host OS to match the base OS of the image we are building. To get around this, we would need to run Docker with HyperV. I've been experimenting with this on #3913, but I hit a Docker issue.

@zerok
Copy link
Author

zerok commented Jun 30, 2025

Ah, too bad 🙁 The only other option I see is to have a self-hosted runner somewhere that runs Windows 2019. Keeping that one secure would be a bit of an undertaking, though 😒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants