-
Notifications
You must be signed in to change notification settings - Fork 363
beyla.ebpf: wire in survey fields #3876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
go.mod
Outdated
@@ -58,7 +58,7 @@ require ( | |||
github.com/gorilla/mux v1.8.1 | |||
github.com/grafana/alloy-remote-config v0.0.10 | |||
github.com/grafana/alloy/syntax v0.1.0 | |||
github.com/grafana/beyla/v2 v2.2.4-alloy | |||
github.com/grafana/beyla/v2 v2.4.2-pre-alloy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @grcevski is this the version version we want to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tagged a new version for Alloy. We'll likely change this in the next week, I want to see if we can make a new release with OpenTelemetry eBPF Instrumentation vendored. For now it's this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed an update which fixes the build problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a stupid thing and force-pushed the branch again while not paying attention 🤦
Did you push any other commits than just update the image to v2.4.3-alloy
here? cc @grcevski
c5ead74
to
d1e9739
Compare
💻 Deploy preview deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks @tpaschalis!
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
This reverts commit 3fe959c.
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
85deb73
to
bce89f4
Compare
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
PR Description
This PR updates the Beyla version and wires in a new field that enables a surveying mechanism for the beyla.ebpf component.
Which issue(s) this PR fixes
No issue filed.
Notes to the Reviewer
PR Checklist