feat: add React Native support #1035
Conversation
…tvavo/faro-web-sdk into feat/add-react-native-support # Conflicts: # packages/react-native-tracing/package.json
…nto feat/add-react-native-support
…tvavo/faro-web-sdk into feat/add-react-native-support
…tvavo/faro-web-sdk into feat/add-react-native-support
…nto feat/add-react-native-support
…tvavo/faro-web-sdk into feat/add-react-native-support
…ro-web-sdk into feat/add-react-native-support
refactor: add a better way to measure startup time
…tvavo/faro-web-sdk into feat/add-react-native-support
|
|
| @@ -145,6 +145,7 @@ export function initializeTransports( | |||
| batchExecutor = new BatchExecutor(batchedSend, { | |||
| sendTimeout: config.batching.sendTimeout, | |||
| itemLimit: config.batching.itemLimit, | |||
| ignoreBrowserApi: config.batching.ignoreBrowserApi, | |||
There was a problem hiding this comment.
Let's remove this option and provide an option to detect the runtime environment so Faro core can automatically toggle between web APIs and mobile APIs and so on.
| @@ -58,4 +58,6 @@ export interface BatchExecutorOptions { | |||
| // Buffer "sendLimit" is the number of signals before sending the payload | |||
| readonly itemLimit?: number; | |||
| readonly paused?: boolean; | |||
|
|
|||
| readonly ignoreBrowserApi?: boolean; | |||
There was a problem hiding this comment.
See comment in packages/core/src/transports/batchExecutor.ts
| this.flush(); | ||
| } | ||
| }); | ||
| if (!options?.ignoreBrowserApi) { |
There was a problem hiding this comment.
See comment in packages/core/src/transports/batchExecutor.ts
| @@ -0,0 +1,52 @@ | |||
| # @grafana/instrumentation-fetch | |||
|
Project structure: move react-native package to experimental as well |
|
@ilia-kurganskii Hey Ilja and team this is absolutely amazing work! I only skimmed over the PR but will do an in-depth review over the next days. See yall and have a great week |
|
Hi @ilia-kurganskii |
codecapitano
changed the base branch from
main
to
react-native-contribution-feature-branch
Why
What
Links
Checklist