chore: update commit hash in readme; add test for delete #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiyu95
reviewed
Feb 10, 2025
|
|
||
| - name: Commit changes | ||
| uses: grafana/github-api-commit-action@ccf9b520c5698380ad3b9619c5add427369b7ef1 # v0.2.0 | ||
| uses: grafana/github-api-commit-action@077642073699d6dd9e9c42a9f69ce517fabf79d2 # v0.3.0 |
There was a problem hiding this comment.
since this is a readme file, does this affect anything? we can use any string here no?
Contributor
Author
There was a problem hiding this comment.
correct, doesn't affect anything, but it does help other devs who may want to use this action they can just copy and paste this code bit and change the params to their liking.
xiyu95
approved these changes
Feb 10, 2025
xiyu95
left a comment
xiyu95
left a comment
There was a problem hiding this comment.
Looks good. One small question on the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.