Fix empty array index lookup - #6
Merged
Merged
Conversation
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
6 tasks
trevorwhitney
approved these changes
Oct 4, 2024
trevorwhitney
left a comment
trevorwhitney
left a comment
There was a problem hiding this comment.
looks good, just a couple questions about an array with empty string, ie [""], thanks!
| {"Empty field array", args{[]byte("{\"data\": []}"), funcError, []string{"data"}}, 10, false}, | ||
| {"Empty field array with space", args{[]byte("{\"data\": [ ]}"), funcError, []string{"data"}}, 11, false}, | ||
| {"Empty field array with \n", args{[]byte("{\"data\": [\n]}"), funcError, []string{"data"}}, 11, false}, | ||
| {"Empty field array with newline", args{[]byte("{\"data\": [\n]}"), funcError, []string{"data"}}, 11, false}, |
There was a problem hiding this comment.
do we need a test for array with an empty string, ie `[]byte("{"data": [""]}"
Author
There was a problem hiding this comment.
As I understood, this is just a test to iterate over an array, not accessing an element by index in that array. The API of this library is rather confusing tbh.
| path: []string{"arrString", "[1]"}, | ||
| expected: "b", | ||
| }, { | ||
| path: []string{"arrString", "[]"}, // [] is equal to [0] |
There was a problem hiding this comment.
again, do we need []string{"arrString", "[\"\"]"}, or maybe that case works?
Author
There was a problem hiding this comment.
[]string{"keys", "[]"}
is what Loki produces when using this parser expression:
| json key[""]
[]string{"keys", "[\"\"]"}
would be equivalent to any other invalid, non-integer array index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: What this PR does
This PR fixes a panic that occurs when the array index is an empty string, as in