Skip to content

fix(canary): Reconnect immediately upon tail max duration - #14287

Merged
MasslessParticle merged 1 commit into
grafana:mainfrom
emadolsky:emadolsky/canary-reconnect-immediately-upon-tail-max-duration
Sep 27, 2024
Merged

fix(canary): Reconnect immediately upon tail max duration#14287
MasslessParticle merged 1 commit into
grafana:mainfrom
emadolsky:emadolsky/canary-reconnect-immediately-upon-tail-max-duration

Conversation

@emadolsky

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Canary latency metrics report high latency every hour as a result of tail_max_duration configuration. As it is possible for canary to recognise this special case, and since there is no need to go through the regular behaviour of sleeping for 10 seconds (which causes the high latency reported), it makes sense to reconnect immediately.

Which issue(s) this PR fixes:
It is related to #5086 but doesn't fix the original issue stated there.
This PR aims to improve the metrics reported by canary.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@emadolsky
emadolsky requested a review from a team as a code owner September 26, 2024 19:35
@CLAassistant

CLAassistant commented Sep 26, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@MasslessParticle MasslessParticle changed the title Fix(canary): Reconnect immediately upon tail max duration Sep 26, 2024
@MasslessParticle

Copy link
Copy Markdown
Contributor

@emadolsky Thanks for contributing! It looks like there's some linting that needs to be fixed before we can merge

@emadolsky
emadolsky force-pushed the emadolsky/canary-reconnect-immediately-upon-tail-max-duration branch 2 times, most recently from a13a7a5 to 91112fd Compare September 27, 2024 09:21
@emadolsky
emadolsky force-pushed the emadolsky/canary-reconnect-immediately-upon-tail-max-duration branch from 91112fd to 13e56ef Compare September 27, 2024 11:38
@emadolsky

Copy link
Copy Markdown
Contributor Author

Hey @MasslessParticle Can I get approval for the workflows?

@MasslessParticle
MasslessParticle merged commit 9267ee3 into grafana:main Sep 27, 2024
@MasslessParticle

Copy link
Copy Markdown
Contributor

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants