fix(canary): Reconnect immediately upon tail max duration - #14287
Merged
MasslessParticle merged 1 commit intoSep 27, 2024
Conversation
MasslessParticle
approved these changes
Sep 26, 2024
Contributor
|
@emadolsky Thanks for contributing! It looks like there's some linting that needs to be fixed before we can merge |
emadolsky
force-pushed
the
emadolsky/canary-reconnect-immediately-upon-tail-max-duration
branch
2 times, most recently
from
September 27, 2024 09:21
a13a7a5 to
91112fd
Compare
emadolsky
force-pushed
the
emadolsky/canary-reconnect-immediately-upon-tail-max-duration
branch
from
September 27, 2024 11:38
91112fd to
13e56ef
Compare
Contributor
Author
|
Hey @MasslessParticle Can I get approval for the workflows? |
Contributor
|
Thanks again! |
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Canary latency metrics report high latency every hour as a result of
tail_max_durationconfiguration. As it is possible for canary to recognise this special case, and since there is no need to go through the regular behaviour of sleeping for 10 seconds (which causes the high latency reported), it makes sense to reconnect immediately.Which issue(s) this PR fixes:
It is related to #5086 but doesn't fix the original issue stated there.
This PR aims to improve the metrics reported by canary.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR