feat(canary): Support passing arbitrary set of labels to use for the query #17008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Loki Canary logs are collected and parsed by logging agents whose configuration is controlled by users. Since Loki does not parse logs directly, the set of labels for each log line is up to users and extremely variable.
The current approach only allows for two labels to be used for the query sent to Loki which can impact the canary's ability to find the logs it is looking for. By adding a
-labels
flag, we are able to pass an arbitrary set of labels to be used in the query. Combined with-query-append
, you can craft a full LogQL query to correctly and efficiently return the logs it is looking for.Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR