Skip to content

Conversation

@benclive
Copy link
Contributor

@benclive benclive commented Nov 8, 2024

What this PR does / why we need it:

I found the path.prefix flag useful for running multiple Loki's locally. It exists as a yaml already, so I just added the flag.
Also configured the kafka ingester KV store for non-memberlist backends, which should be configurable. It is useful for running locally too.

@benclive benclive requested a review from a team as a code owner November 8, 2024 15:49
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Nov 8, 2024
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 8, 2024
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Nov 8, 2024
@benclive benclive merged commit f2da621 into main Nov 8, 2024
60 checks passed
@benclive benclive deleted the add-useful-flags branch November 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

2 participants