Skip to content

fix: Add flags for path & configure kafka for non-memberlist kv store #14850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2024
Merged

fix: Add flags for path & configure kafka for non-memberlist kv store #14850

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e19e7c
fix: Add flags for path & configure kafka for non-memberlist kv store
benclive Nov 8, 2024
6fc0411
docs
benclive Nov 8, 2024
3f688a9
docs again
benclive Nov 8, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Add flags for path & configure kafka for non-memberlist kv store
  • Loading branch information
@benclive
benclive committed Nov 8, 2024
commit 7e19e7c2a039bc40807478ba4eb78ea4148a78a2
1 change: 1 addition & 0 deletions pkg/loki/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ func (c *Config) RegisterFlags(f *flag.FlagSet) {

f.StringVar(&c.CompactorAddress, "common.compactor-address", "", "the http address of the compactor in the form http://host:port")
f.StringVar(&c.CompactorGRPCAddress, "common.compactor-grpc-address", "", "the grpc address of the compactor in the form host:port")
f.StringVar(&c.PathPrefix, "common.path-prefix", "", "prefix for the path")
}

type Storage struct {
Expand Down
1 change: 1 addition & 0 deletions pkg/loki/config_wrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ func applyConfigToRings(r, defaults *ConfigWrapper, rc lokiring.RingConfig, merg
r.Ingester.LifecyclerConfig.Zone = rc.InstanceZone
r.Ingester.LifecyclerConfig.ListenPort = rc.ListenPort
r.Ingester.LifecyclerConfig.ObservePeriod = rc.ObservePeriod
r.Ingester.KafkaIngestion.PartitionRingConfig.KVStore = rc.KVStore
}

if mergeWithExisting {
Expand Down
Loading