Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use context propagation to use the same ingester in GetChunksID #15186

Merged
merged 4 commits into from
Dec 4, 2024
Merged

feat: Use context propagation to use the same ingester in GetChunksID #15186

merged 4 commits into from
Dec 4, 2024

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

@benclive WDYT ?

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@cyriltovena cyriltovena changed the title Use context propagation to use the same ingester in GetChunksID Nov 29, 2024
@cyriltovena cyriltovena marked this pull request as ready for review December 4, 2024 10:53
@cyriltovena cyriltovena requested a review from a team as a code owner December 4, 2024 10:53
@benclive benclive merged commit 70d9587 into grafana:main Dec 4, 2024
58 checks passed
benclive added a commit that referenced this pull request Dec 4, 2024
@cyriltovena @benclive
feat: Use context propagation to call the same ingester in GetChunksI…
1b6405e 
…D as Query (#15186)

Co-authored-by: Ben Clive <ben.clive@grafana.com>
@benclive benclive deleted the partition-context branch December 5, 2024 10:46
This was referenced Dec 23, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 6, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Closed
This was referenced Feb 3, 2025
Closed
Merged
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L
2 participants
@cyriltovena @benclive