Skip to content

feat: Use context propagation to use the same ingester in GetChunksID #15186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2024
Merged

feat: Use context propagation to use the same ingester in GetChunksID #15186

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6505123
Use context propagation to use the same ingester in GetChunksID
cyriltovena Nov 29, 2024
763a861
tidy & write test
benclive Nov 29, 2024
b74d577
add timeout to forQueriedIngesters calls
benclive Nov 29, 2024
9027d4d
handle bad ingesters in partition-ctx
benclive Nov 29, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add timeout to forQueriedIngesters calls
  • Loading branch information
@benclive
benclive committed Nov 29, 2024
commit b74d577c0348623338f9c9116d258903ab4612b0
4 changes: 4 additions & 0 deletions pkg/querier/ingester_querier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ func (p *PartitionContext) forQueriedIngesters(ctx context.Context, f func(conte
p.mtx.Lock()
defer p.mtx.Unlock()

var cancel context.CancelFunc
ctx, cancel = context.WithTimeout(ctx, 5*time.Second)
defer cancel()

return concurrency.ForEachJobMergeResults(ctx, p.ingestersUsed, 0, func(ctx context.Context, job PartitionIngesterUsed) ([]responseFromIngesters, error) {
resp, err := f(ctx, job.client)
if err != nil {
Expand Down