Skip to content

fix(ci): Pass image tag details to logcli docker build #16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

paul1r
Copy link
Collaborator

@paul1r paul1r commented Feb 10, 2025

What this PR does / why we need it:
Follow on to #15939. This adds build info to the logcli Docker image.

% docker run docker.io/grafana/logcli:paul1r-fix_build_info_logcli-656b1fa-WIP  --version
logcli, version  (branch: paul1r/fix_build_info_logcli, revision: 656b1faaa)
  build user:       root@buildkitsandbox
  build date:       2025-02-10T14:13:41Z
  go version:       go1.23.6
  platform:         linux/arm64
  tags:             netgo

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@paul1r paul1r requested a review from a team as a code owner February 10, 2025 14:16
@paul1r paul1r merged commit f22527f into main Feb 10, 2025
59 checks passed
@paul1r paul1r deleted the paul1r/fix_build_info_logcli branch February 10, 2025 15:35
@paul1r paul1r added the type/ci label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants