Skip to content

fix: Revert "feat: Assert for bad max_query_lookback config (#16362)" #16441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

DylanGuedes
Copy link
Contributor

This reverts commit 073c94c.

What this PR does / why we need it:
I'm reverting this check because the way it evaluates tenants can cause concurrent problems when generating the jsonnet manifests. For now I'm reverting to unblock future weekly releases and I'll look into a better way of implementing this check.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@DylanGuedes DylanGuedes requested a review from a team as a code owner February 25, 2025 15:35
@DylanGuedes DylanGuedes merged commit 42ddb68 into main Feb 25, 2025
59 checks passed
@DylanGuedes DylanGuedes deleted the revert-retention-check branch February 25, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants