Skip to content

feat: Assert for bad max_query_lookback config #16362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

DylanGuedes
Copy link
Contributor

What this PR does / why we need it:
Add a new assert to our jsonnet manifest that checks that there's no tenant with a retention period that can't be queried (due to low max_query_lookback)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@DylanGuedes DylanGuedes requested a review from a team as a code owner February 18, 2025 19:44
@DylanGuedes DylanGuedes merged commit 073c94c into main Feb 19, 2025
58 checks passed
@DylanGuedes DylanGuedes deleted the check-for-wrong-query-lookback branch February 19, 2025 15:36
DylanGuedes added a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants